Cleanup unused methods #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 5, 2021
533: Cleanup unused methods r=charleskawczynski a=charleskawczynski We can now get rid of `center_field`! 🎉 This PR also removes get/set index support for the face-`k` indices (since they're no longer used), so that nobody can accidentally put them back in. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
charleskawczynski
force-pushed
the
ck/cleanup2
branch
from
e37b91b
to
0a81984
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
charleskawczynski
referenced
this pull request
Nov 9, 2021
511: Use relaxation to LES profiles + define initial conditions more precisely for LES_driven_SCM r=costachris a=costachris Addresses points 4, 7 from #505. Averages 1 hour window around `t_end` - 6 hours for initial conditions. `thetali` and `qt` are relaxed to the mean LES profile following eqn 9 in Shen et al. 2021 Co-authored-by: costachris <christopouloscosta@gmail.com>
charleskawczynski
referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now get rid of
center_field! 🎉This PR also removes get/set index support for the face-We can't get rid of that support yet, since we still grab data from arrays in some surface routines.kindices (since they're no longer used), so that nobody can accidentally put them back in.