Make diag dict field entry a state-accepting func #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 10, 2021
554: Make diag dict field entry a state-accepting func r=charleskawczynski a=charleskawczynski This is a peel-off from #473. Basically, this PR changes the diagnostics dict field entry from a reference to the input state to a function that accepts the state. As a result, `io_dictionary_diagnostics`,`io_dictionary_aux`, etc. do not need the input state, and the dict acts in a more functional way. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
charleskawczynski
force-pushed
the
ck/io_dict
branch
from
9a00e2e
to
b444446
Compare
|
bors r+ |
|
bors r- |
|
Canceled. |
charleskawczynski
force-pushed
the
ck/io_dict
branch
from
b444446
to
9e7ecd5
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a peel-off from #473. Basically, this PR changes the diagnostics dict field entry from a reference to the input state to a function that accepts the state. As a result,
io_dictionary_diagnostics,io_dictionary_aux, etc. do not need the input state, and the dict acts in a more functional way.