Move updraft_top to update_aux! #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairchn
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
LGTM, @trontrytel , @ilopezgp - this bug fix will have behavioral change on the simualtions (especially TRMM) - but it is following a change to Julia.17
charleskawczynski
force-pushed
the
ck/diagnostics
branch
from
485c2a3
to
9d7cf06
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2021
625: Move updraft_top to update_aux! r=charleskawczynski a=charleskawczynski Closes #550. This PR move `updraft_top`, which the model depends on, from `compute_diagnostics!` to `update_aux!`. This PR also moves the `GMV_third_m` computations into `compute_diagnostics!`, since they are purely diagnostic and the model does not depend on them. cc `@ilopezgp,` `@trontrytel` Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550. This PR move
updraft_top, which the model depends on, fromcompute_diagnostics!toupdate_aux!. This PR also moves theGMV_third_mcomputations intocompute_diagnostics!, since they are purely diagnostic and the model does not depend on them.cc @ilopezgp, @trontrytel