Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI, update compat and CLIMAParameters call func call #650

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Fix CI, update compat and CLIMAParameters call func call #650

merged 1 commit into from
Dec 14, 2021

Conversation

trontrytel
Copy link
Member

@charleskawczynski this should be the fix

@trontrytel trontrytel self-assigned this Dec 14, 2021
yairchn
yairchn approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@yairchn yairchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trontrytel
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Dec 14, 2021
@bors
Try #650:
c0bda82
@bors
Copy link
Contributor

bors bot commented Dec 14, 2021

try

Build failed:

@charleskawczynski charleskawczynski changed the title update to new parameter name Fix CI, update compat and CLIMAParameters call func call Dec 14, 2021
@charleskawczynski
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 14, 2021
@bors @trontrytel
Merge #650
5e1565a 
650: Fix CI, update compat and CLIMAParameters call func call r=charleskawczynski a=trontrytel

`@charleskawczynski` this should be the fix

Co-authored-by: Anna Jaruga <ajaruga@caltech.edu>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2021

Build failed:

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 14, 2021

Build succeeded:

@bors bors bot merged commit 6040609 into main Dec 14, 2021
@bors bors bot deleted the aj/micro_fix branch December 14, 2021 22:44
@charleskawczynski charleskawczynski mentioned this pull request Dec 14, 2021
Closed
charleskawczynski referenced this pull request Dec 18, 2021
@bors @charleskawczynski
Merge #663
f18233a 
663: Bump version for new release r=charleskawczynski a=charleskawczynski



Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski approved these changes

@yairchn yairchn yairchn approved these changes

Assignees

@trontrytel trontrytel

Labels
Continuous Integration ⚙️ Microphysics 🌨️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trontrytel @charleskawczynski @yairchn