Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change of grid mean prognostic variables #956

Merged
merged 1 commit into from
May 4, 2022
Merged

change of grid mean prognostic variables #956

merged 1 commit into from
May 4, 2022

Conversation

yairchn
Copy link
Member

@yairchn yairchn commented Apr 28, 2022

In this PR I take the first step in modifying the grid mean prognostic variables.
The current PR changes are from
θ_liq_ice --> ρθ_liq_ice
q_tot --> ρq_tot
I do so will adding θ_liq_ice and q_tot to the aux_gm fields and using it in places.
My hope is that once I change to ρθ_liq_ice --> ρe_tot we can add aux_up.e_tot and aux_en.e_tot for computing the SGS energy flux while effectively not requiring any mathematical translation of the flux from θ_liq_ice to energy.

@yairchn yairchn changed the title Yc/gm energy change of grid mean prognostic variable Apr 28, 2022
@yairchn yairchn changed the title change of grid mean prognostic variable change of grid mean prognostic variables Apr 28, 2022
@yairchn yairchn force-pushed the yc/gm_energy branch 13 times, most recently from 14aa60b to bbcf339 Compare May 3, 2022 23:45
Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great, I think you just need to

  • Update the mse tables
  • Update your local version of the julia formatter (julia --project=.dev ] up), then apply the formatter
  • Fix the --entr FNO case
  • Fix the --entr NN_nonlocal case

@yairchn yairchn force-pushed the yc/gm_energy branch 5 times, most recently from ff67610 to 3f90c1b Compare May 4, 2022 04:15
@yairchn
Copy link
Member Author

yairchn commented May 4, 2022

Bors r+

@bors
Copy link
Contributor

bors bot commented May 4, 2022

Build succeeded:

@bors bors bot merged commit 92ed24b into main May 4, 2022
@bors bors bot deleted the yc/gm_energy branch May 4, 2022 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants