Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update microjson #421

Closed
pbsds opened this issue Sep 13, 2023 · 4 comments
Closed

Please update microjson #421

pbsds opened this issue Sep 13, 2023 · 4 comments

Comments

@pbsds
Copy link
Contributor

pbsds commented Sep 13, 2023

Hi, I'm packaging pagefind into nixpkgs, and we struggle with git dependencies in cargo.

You seem to include a git reference to microjson:

pagefind/Cargo.lock

Lines 1676 to 1679 in 5750761

[[package]]
name = "microjson"
version = "0.1.4"
source = "git+https://github.com/rspencer01/microjson.git?rev=379b16211a81805856be0b2ac14643a54d96b45a#379b16211a81805856be0b2ac14643a54d96b45a"

Could you update this to a non git+... dependency? Much appreciated.

@bglw
Copy link
Contributor

bglw commented Sep 13, 2023

Hi @pbsds — good to know!

I have another change to include in a 1.0.1, so I can include this. I'm blocked by a bug on the crates release of microjson, but I can do a temporary fork and publish a crate at that commit to unblock you. Will be in touch later today

@pbsds
Copy link
Contributor Author

pbsds commented Sep 13, 2023

There is a 50/50 chance a reviewer will find it problematic or not that i vendor the lock as a fix so it is not a total block, but please do keep me posted.

Congrats on 1.0.0 🚀

@bglw
Copy link
Contributor

bglw commented Sep 13, 2023

Just publishing a 1.0.1-rc1 release now to test both fixes — should have something out today assuming nothing else comes up 👍

@bglw
Copy link
Contributor

bglw commented Sep 14, 2023

Hi @pbsds — this should now be resolved in v1.0.1 by using pagefind_microjson while we wait for a microjson stable release. Let me know if you're still seeing any issues!

@bglw bglw closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants