Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Roslyn multi-targeting for MVVM Toolkit generator #423

Closed
Sergio0694 opened this issue Sep 7, 2022 · 0 comments · Fixed by #428
Closed

Enable Roslyn multi-targeting for MVVM Toolkit generator #423

Sergio0694 opened this issue Sep 7, 2022 · 0 comments · Fixed by #428
Assignees
@Sergio0694
Labels
build 🔥 Some changes or issues related to build infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Comments

@Sergio0694
Copy link
Member

Sergio0694 commented Sep 7, 2022 •
edited
Loading

Overview

We should enable multi-targeting in the MVVM Toolkit generator so we can safely use 4.3+ APIs when possible.
Specifically, we need ForAttributeWithMetadataName.
@Sergio0694 Sergio0694 added feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 7, 2022
@Sergio0694 Sergio0694 self-assigned this Sep 7, 2022
@Sergio0694 Sergio0694 added build 🔥 Some changes or issues related to build infrastructure and removed feature request 📬 A request for new changes to improve functionality labels Sep 7, 2022
@Sergio0694 Sergio0694 mentioned this issue Sep 8, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sergio0694 Sergio0694

Labels
build 🔥 Some changes or issues related to build infrastructure mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multi-target Roslyn dependency in MVVM Toolkit generators CommunityToolkit/dotnet
1 participant
@Sergio0694