Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CLI query commands for the other query services for ratelimit module #240

Open
jaybxyz opened this issue Sep 23, 2023 · 3 comments · May be fixed by #241
Open

Support CLI query commands for the other query services for ratelimit module #240

jaybxyz opened this issue Sep 23, 2023 · 3 comments · May be fixed by #241
Assignees

Comments

@jaybxyz
Copy link
Contributor

jaybxyz commented Sep 23, 2023

At the moment, CLI query commands only support the AllRateLimits query. I suggest to add the other query commands.

type QueryServer interface {
	AllRateLimits(context.Context, *QueryAllRateLimitsRequest) (*QueryAllRateLimitsResponse, error)
	RateLimit(context.Context, *QueryRateLimitRequest) (*QueryRateLimitResponse, error)
	RateLimitsByChainID(context.Context, *QueryRateLimitsByChainIDRequest) (*QueryRateLimitsByChainIDResponse, error)
	RateLimitsByChannelID(context.Context, *QueryRateLimitsByChannelIDRequest) (*QueryRateLimitsByChannelIDResponse, error)
	AllWhitelistedAddresses(context.Context, *QueryAllWhitelistedAddressesRequest) (*QueryAllWhitelistedAddressesResponse, error)
}
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Sep 23, 2023

This shouldn't be an urgent issue i believe. I am happy to contribute if you like.

@vuong177
Copy link
Contributor

Sure! Thank you, @jaybxyz !

@dzmitry-lahoda
Copy link
Contributor

upgrade to mainline module with query, not fork instead of fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants