Add test_account_hash #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The account hashing function is not exposed in public interface of any of the Solana crates so when we need to use it in the light client we need to copy the code. Copying may introduce bugs so it’s crucial to test other implementations. Add a test_account_hash which calculates account hash with fixed values. The main purpose of this test is that other implementations of account hashing can copy it over to verify their code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The account hashing function is not exposed in public interface of any of the Solana crates so when we need to use it in the light client we need to copy the code. Copying may introduce bugs so it’s crucial to test other implementations.
Add a test_account_hash which calculates account hash with fixed values. The main purpose of this test is that other implementations of account hashing can copy it over to verify their code.