Fail fast on wasmvm cache metric setup

CosmWasm · Aug 28, 2023 · 4595e6d · 4595e6d
1 parent 7c6069d
commit 4595e6d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/x/wasm/keeper/metrics.go b/x/wasm/keeper/metrics.go
@@ -29,6 +29,9 @@ type WasmVMMetricsCollector struct {
 
 // NewWasmVMMetricsCollector constructor
 func NewWasmVMMetricsCollector(s metricSource) *WasmVMMetricsCollector {
+	if s == nil {
+		panic("wasmvm instance must not be nil")
+	}
 	return &WasmVMMetricsCollector{
 		source:             s,
 		CacheHitsDescr:     prometheus.NewDesc("wasmvm_cache_hits_total", "Total number of cache hits", []string{"type"}, nil),

diff --git a/x/wasm/keeper/options_test.go b/x/wasm/keeper/options_test.go
@@ -1,6 +1,7 @@
 package keeper
 
 import (
+	"github.com/prometheus/client_golang/prometheus"
 	"reflect"
 	"testing"
 
@@ -31,6 +32,15 @@ func TestConstructorOptions(t *testing.T) {
 				assert.IsType(t, &wasmtesting.MockWasmer{}, k.wasmVM)
 			},
 		},
+		"vm cache metrics": {
+			srcOpt: WithVMCacheMetrics(prometheus.DefaultRegisterer),
+			verify: func(t *testing.T, k Keeper) {
+				t.Helper()
+				registered := prometheus.DefaultRegisterer.Unregister(NewWasmVMMetricsCollector(k.wasmVM))
+				assert.True(t, registered)
+			},
+			isPostOpt: true,
+		},
 		"decorate wasmvm": {
 			srcOpt: WithWasmEngineDecorator(func(old types.WasmerEngine) types.WasmerEngine {
 				require.IsType(t, &wasmvm.VM{}, old)