Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper v1 gov support for wasm msg types #1301

Closed
alpe opened this issue Mar 29, 2023 · 1 comment · Fixed by #1326
Closed

Proper v1 gov support for wasm msg types #1301

alpe opened this issue Mar 29, 2023 · 1 comment · Fixed by #1326
Assignees

Comments

@alpe
Copy link
Contributor

alpe commented Mar 29, 2023

Follow up on #1269

The v1 gov module comes with a new draft-proposal command to support the proposal file creation. It is based on reflection and the promptui lib.
Unfortunately this does not work out of the box with our more complex message types. See the proto file for all current types.

We need to provide an alternative:
a) A wizard can be convenient for humans but mostly does not work nicely with (test) scripts
b) Reverting back to v1beta1 proposal types would be an option but not solving the problem for the future
c) A new wasm command could provide a similar interface as v1beta1 proposals but with a v1 message send
d) A new generic wasm command could extract the message for the tx body for any generated msg. Basically same as jq -r '.body.messages' + header file. It could be used like
wasmd tx wasm store "./x/wasm/keeper/testdata/hackatom.wasm" -o json --keyring-backend=test --from mykey --generate-only | wasmd tx wasm extract path/to/proposal.json and then send via wasmd tx gov submit-proposal [path/to/proposal.json]

@alpe alpe added this to the v0.40.0 - sdk 47 support milestone Mar 29, 2023
@alpe alpe changed the title Add proposal wizard for v1 gov Proper v1 gov support for wasm msg types Mar 30, 2023
@alpe alpe mentioned this issue Mar 30, 2023
@pinosu pinosu self-assigned this Apr 10, 2023
@alpe
Copy link
Contributor Author

alpe commented May 2, 2023

Option c) us recommended: cosmos/cosmos-sdk#15982 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants