Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tracking of CosmWasm capabilities #1341

Closed
alpe opened this issue Apr 17, 2023 · 1 comment · Fixed by #1361
Closed

Better tracking of CosmWasm capabilities #1341

alpe opened this issue Apr 17, 2023 · 1 comment · Fixed by #1361
Assignees

Comments

@alpe
Copy link
Contributor

alpe commented Apr 17, 2023

They are currently defined in a string in app.go. Updates can be missed easily as the file is quite big already.

Some ideas:

  • extract to a dedicated method that returns []string, format in app.go with strings.Join
  • new file in /app that contains the new method
@webmaster128
Copy link
Member

webmaster128 commented Apr 18, 2023

Using a string array (or better set if you have that type available) is the right thing to do here. The only reason this is a comma separated list in wasmvm is the FFI boundary to Rust. We should have internalized this string representation from the beginning.

CosmWasm/wasmvm#425

@alpe alpe added this to the v0.40.0 - sdk 47 support milestone Apr 21, 2023
@alpe alpe self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants