Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshaler to codec #1545

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 4, 2023

SDK has changed verbiage and this PR changes the term "marshaler" to
codec to match

@faddat faddat requested a review from alpe as a code owner August 4, 2023 07:29
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1545 (47f19f6) into main (ae964a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
+ Coverage   58.00%   58.03%   +0.02%     
==========================================
  Files          64       64              
  Lines        8640     8640              
==========================================
+ Hits         5012     5014       +2     
+ Misses       3215     3214       -1     
+ Partials      413      412       -1     
Files Changed Coverage Δ
app/app.go 86.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

tests/e2e/ibc_fees_test.go Outdated Show resolved Hide resolved
tests/e2e/ibc_fees_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Just few small changes are required, then it is good to go! 💯

faddat and others added 3 commits August 4, 2023 19:06
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pinosu pinosu merged commit dc970c4 into CosmWasm:main Aug 4, 2023
8 checks passed
faddat added a commit to faddat/wasmd that referenced this pull request Aug 20, 2023
* marshaler to codec

* Update tests/e2e/ibc_fees_test.go

Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>

* Update tests/e2e/ibc_fees_test.go

Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>

* fix a few remaining issues

---------

Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants