Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast on empty wasmvm cache metric setup #1576

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fail fast on empty wasmvm cache metric setup #1576

merged 1 commit into from
Aug 28, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 28, 2023

Follow up on #1574 + #1575

Test and panic to be on the safe side

@alpe alpe requested a review from pinosu August 28, 2023 11:26
@alpe alpe changed the title Fail fast on wasmvm cache metric setup Fail fast on empty wasmvm cache metric setup Aug 28, 2023
@alpe alpe added the backport/v0.3x Backport patches to sdk45 release branch label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #1576 (4595e6d) into main (7c6069d) will increase coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
+ Coverage   58.00%   58.20%   +0.19%     
==========================================
  Files          64       64              
  Lines        8640     8642       +2     
==========================================
+ Hits         5012     5030      +18     
+ Misses       3215     3198      -17     
- Partials      413      414       +1
Files Changed Coverage Δ
x/wasm/keeper/metrics.go 50.00% <0.00%> (+50.00%) ⬆️

... and 1 file with indirect coverage changes

pinosu
pinosu approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 78b5af2 into main Aug 28, 2023
15 of 16 checks passed
@alpe alpe deleted the 1575_test branch August 28, 2023 12:50
@mergify mergify bot mentioned this pull request Aug 28, 2023
Merged
alpe added a commit that referenced this pull request Aug 31, 2023
@mergify @alpe
Fail fast on empty wasmvm cache metric setup (backport #1576) (#1580)
4643ce9 
* Fail fast on wasmvm cache metric setup

(cherry picked from commit 4595e6d)

* Adjust to the branch

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
backport/v0.3x Backport patches to sdk45 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu