Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple Steam userIDs in the install script #7

Open
CrumblyLiquid opened this issue Jan 24, 2024 · 6 comments
Open

Support for multiple Steam userIDs in the install script #7

CrumblyLiquid opened this issue Jan 24, 2024 · 6 comments

Comments

@CrumblyLiquid
Copy link
Owner

No description provided.

@Ciflire
Copy link

Ciflire commented Apr 13, 2024

Hi,
the install.sh is broken here you might wanna change that line into WINEDEBUG=-all protontricks-launch --appid 252950 $E_ZIP/BakkesModSetup.exe, this launches the installer inside the proton "container" of rocket league.
Also, you might want to change this line to use regex for steam/steamwebhelper

@CrumblyLiquid
Copy link
Owner Author

Hi!
install.sh should now actually launch the executable. Thanks for the fix!
I also added some improvements to install.sh and bakkes.sh.

As for changing while killall -0 steam &> /dev/null; do I'm not sure why.

@Ciflire
Copy link

Ciflire commented Apr 15, 2024

Nice work, your installation script works out of the box, i just tried it on a fresh install. Everything works fine, just had to set the launch options, it seems that the localconfig.vdfis located under .local/share/Steam/userdata/[userId different from 0]/config/localconfig.vdf . On a friends computer it's also located in that path, with a different userId.

For the second point, if I understood correctly the point of this line, it's to kill steam, to be sure it's not trying to use the vdf file, but killing the steam executable is not enough, most of the time, killing steamwebhelper does actually kill the thing. Right now, it is stuck on setting the launch options because of that, until i manually kill Steam. But I might be mistaken on what you wanted to do here.

@CrumblyLiquid
Copy link
Owner Author

Thanks!

Everything works fine, just had to set the launch options, it seems that the localconfig.vdfis located under .local/share/Steam/userdata/[userId different from 0]/config/localconfig.vdf. On a friends computer it's also located in that path, with a different userId.

The problem is that modcfg.py fails to find the correct path?

For the second point, if I understood correctly the point of this line, it's to kill steam, to be sure it's not trying to use the vdf file

It's just a waiting for Steam to exit (not actually killing Steam).

I don't really want to kill Steam unpromted so I just send it signal 0 (doesn't send anything but still does error checking) to test if it's running or not. If it's not running killall returns non-zero value and the while loop stops running.

@Ciflire
Copy link

Ciflire commented Apr 15, 2024

The problem is that modcfg.py fails to find the correct path?

All right I miss one info. It does not work for me because I have to user accounts for some reasons. But I saw that you left a TODO in your code for multiple users. For singleuser users I just assume it'll work properly. Great work again and thank you for your work!

It's just a waiting for Steam to exit (not actually killing Steam).

I don't really want to kill Steam unpromted so I just send it signal 0 (doesn't send anything but still does error checking) to test if it's running or not. If it's not running killall returns non-zero value and the while loop stops running.

Ok np. Maybe a more explicit message could be more user friendly smth like "Please close steam for the installation process to resume" ? That's my impression, maybe some external input could be good too

@CrumblyLiquid
Copy link
Owner Author

CrumblyLiquid commented Apr 17, 2024

It does not work for me because I have two user accounts for some reasons.

Yeah I'll have to borrow another account to test this. I'm not sure when I get around to that.
In the meantime one could modify this line to point to the correct folder.
Something like userid = Path(steam_path, "userdata/<your_id>")

Maybe a more explicit message could be more user friendly smth like "Please close steam for the installation process to resume" ?

Fixed here 3e21096. Thank you for the feedback!

@CrumblyLiquid CrumblyLiquid changed the title Fix bakkes.sh if Support for multiple Steam userIDs in the install script Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants