Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image embeds may be crashing the plugin #16

Open
seantiz opened this issue Jan 13, 2024 · 3 comments
Open

Image embeds may be crashing the plugin #16

seantiz opened this issue Jan 13, 2024 · 3 comments
Assignees
Labels
bug Something isn't working roadmap

Comments

@seantiz
Copy link

seantiz commented Jan 13, 2024

This has proved a very useful plugin so far. The one issue I ran into is a .png embed in a note brought the plugin to crash each time.

In a different note with a .jpg embed (and far less markdown code attached to it) there was no problem. I believe the difference with the .png embed isn't necessarily the format, but that the markdown code in the embed attachment has a LOT more characters in it.

@CtrlAltFocus
Copy link
Owner

Sorry for not having responded in this topic earlier, I saw the notification via email and noted it.

Haven't had the time to work on this till now.
I'll start looking at a fix for this issue this week, while working on ollama localhost/open-source AI support.

@CtrlAltFocus CtrlAltFocus self-assigned this Feb 19, 2024
@CtrlAltFocus CtrlAltFocus added the bug Something isn't working label Feb 19, 2024
@seantiz
Copy link
Author

seantiz commented Feb 19, 2024

No problem! if could be that i was sending too much for GPT3.5 to tokenise. that's my best guess.

@CtrlAltFocus
Copy link
Owner

Might be! In that case, still is an issue :-)
The plugin should warn about that, and either not allow it, or cut off at the limit or make multiple requests (or let the user decide :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working roadmap
Projects
None yet
Development

No branches or pull requests

2 participants