Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show broker fee per swap [150 FLIP] #79

Closed
CumpsD opened this issue Aug 7, 2024 · 3 comments
Closed

Show broker fee per swap [150 FLIP] #79

CumpsD opened this issue Aug 7, 2024 · 3 comments
Labels
enhancement New feature or request funded Funded and ready to start

Comments

@CumpsD
Copy link
Owner

CumpsD commented Aug 7, 2024

Show broker fee per swap

Scope

Right now a swap shows the delta between USD in and USD out, this can be misleading to believe Chainflip's pricing is not good when there is a broker charging high fees.

If we would split out the broker fee from the delta and display it separately it would more accurately represent the protocol.

More Info

Fees are split out in the graphql response, parse out the broker one and deduct it from the delta.

Bounty

FLIP required for development: 150 FLIP
To start development, send the bounty to 0x2578f4fa0f36138c76389095bf74331a4f57bcc0 and comment with a link to the transaction.

@CumpsD CumpsD added enhancement New feature or request waiting for funding Waiting for funding to start labels Aug 7, 2024
@Haafingar
Copy link

Chainflip Labs will fund this

@CumpsD
Copy link
Owner Author

CumpsD commented Aug 23, 2024

@CumpsD CumpsD added funded Funded and ready to start and removed waiting for funding Waiting for funding to start labels Aug 23, 2024
@CumpsD
Copy link
Owner Author

CumpsD commented Aug 23, 2024

Image

Broker fee is now present on telegram, discord, twitter, mastodon, as well as a refactor a multiline format and better emojis.

@CumpsD CumpsD closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funded Funded and ready to start
Projects
Status: Done
Development

No branches or pull requests

2 participants