Performance degradation in 2.7.6+ #344
Comments
|
The majority of the time spent seems to be in PackageURL.canonicalize(). In 2.7.5 there were 12,214 invocations accounting for 31ms (plus 20ms for constructor) . In 2.7.7 there are 21,996,184 invocations accounting for 35,273ms (plus 31,145ms for constructor). |
|
FYI, this is what the project dependency tree looks like: |
|
IIUC, it's https://github.com/opendaylight/aaa ? |
correct, it is currently using 2.7.5. Attempting to bump to 2.7.6 (via https://git.opendaylight.org/gerrit/c/aaa/+/105524) ends up exceeding 60 minutes build time, and thus fails to verify with: I have verified locally 2.7.7 behaves essentially the same. |
|
@knrc Aether / Maven Resolver API is much more chatty (many more dependency nodes) than previous Maven Dependency Graph: we'll need to optimize to cut the dependency graph when it's useful... |
|
@hboutemy Chatty in what way? IIRC it should be the same nodes as the maven one (different type obviously) but with direct access to the winner information hidden by the maven tree. |
|
I can take a look at this and see what is going on |
|
@rovarga @hboutemy I've rebased my changes for #311 onto master and submitted a PR, see #345 I'm seeing the following results with the 2.7.5 2.7.6 2.7.7 2.7.8-SNAPSHOT @rovarga can you please try this locally and see how it performs for you? |
I can confirm this fixes the performance issue. Tracing also indicates there are only 2577 invocations of PackageURL.canonicalize(). Thanks for the quick turnaround! :) |
|
@rovarga Thanks for the confirmation. There's one thing left for me to do with that PR, not related to your use case, so I'll try to get it completed as quickly as I can. |
|
fixed by #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
makeBomexecution suffers a massive performance degradation since 2.7.6, also present in 2.7.7:With 2.7.5:
With 2.7.7:
The crux of the problem seems to lie in DefaultModelConverter.generatePackageUrl() and DefaultProjectDependenciesConverter.buildDependencyGraphNode() -- these get called ~22M and ~7M times respectively.
The text was updated successfully, but these errors were encountered: