Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts are vulnerable to fee-on-transfer-token-related accounting issues #1112

Open
codehawks-bot opened this issue Aug 5, 2023 · 0 comments
Open

Contracts are vulnerable to fee-on-transfer-token-related accounting issues #1112

codehawks-bot opened this issue Aug 5, 2023 · 0 comments
Labels
finding-fot-collateral medium

Comments

@codehawks-bot
Copy link

Contracts are vulnerable to fee-on-transfer-token-related accounting issues

Severity

Medium Risk

Summary

Without measuring the balance before and after the transfer, there's no way to ensure that enough tokens were transferred, in the cases where the token has a fee-on-transfer mechanic. If there are latent funds in the contract, subsequent transfers will succeed.

Tools Used

Manual Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
finding-fot-collateral medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hans-cyfrin @codehawks-bot