Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burnDSC - Optimization/Informational #1149

Open
codehawks-bot opened this issue Aug 5, 2023 · 0 comments
Open

burnDSC - Optimization/Informational #1149

codehawks-bot opened this issue Aug 5, 2023 · 0 comments

Comments

@codehawks-bot
Copy link

burnDSC - Optimization/Informational

Severity

Gas Optimization / Informational

Summary

the _revertIfHealthFactorIsBroken(msg.sender) in burnDSC function is redundant since it is used to burn user's minted DSC to improve user's health factor. So, we dont need this check because we are burning not minting.

Vulnerability Details

Impact

No potential impact

Tools Used

Manual Review

Recommendations

Remove _revertIfHealthFactorIsBroken(msg.sender) and maybe be return updated health factor after burning DSC. So, the user would know if their health factor is good or broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants