Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat bug with mikeio>2.0 #718

Closed
daniel-caichac-DHI opened this issue Aug 21, 2024 · 1 comment · Fixed by #719
Closed

Concat bug with mikeio>2.0 #718

daniel-caichac-DHI opened this issue Aug 21, 2024 · 1 comment · Fixed by #719

Comments

@daniel-caichac-DHI
Copy link

daniel-caichac-DHI commented Aug 21, 2024

Hi,

I think there is an issue with generic.concat and dfs0 files at least.
The documentation of generic.concat says that it should work with keep either first or last

image
But the documentation of _dataset.py says that it only works with last

image

Well, I am using generic.concat, and instead of calling generic.concat, it is going to dataset.concat apparently

image

  • Just tried with mikeio 2.0.0 and 2.0.1, same conclusion.

  • I downgraded to 1.7.1 and same script now works fine

@ecomodeller
Copy link
Member

Thx for reporting this, the reason for this was that concatenating dfs0 files looping over every timestep is a bit slow. But I missed the fact that only one keep option was available.

@ecomodeller ecomodeller linked a pull request Aug 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants