Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Dfsu spectral files directions conversion #728

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Fix bug in Dfsu spectral files directions conversion #728

merged 9 commits into from
Sep 25, 2024

Conversation

jsmariegaard
Copy link
Member

Only convert directional axis to degrees if in radians

Closes #724

@jsmariegaard jsmariegaard marked this pull request as ready for review September 20, 2024 07:46
ryan-kipawa
ryan-kipawa approved these changes Sep 25, 2024
View reviewed changes
Copy link

@ryan-kipawa ryan-kipawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

mikeio/dfsu/_spectral.py Show resolved Hide resolved
@jsmariegaard jsmariegaard merged commit 97237c1 into main Sep 25, 2024
5 checks passed
@jsmariegaard jsmariegaard deleted the directions-conversion branch September 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-kipawa ryan-kipawa ryan-kipawa approved these changes

@ecomodeller ecomodeller Awaiting requested review from ecomodeller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faulty conversion of direction on read() in _spectral.py
2 participants
@jsmariegaard @ryan-kipawa