Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSM6DSOX Consolidation #167

Open
crsz20 opened this issue Feb 13, 2024 · 0 comments
Open

LSM6DSOX Consolidation #167

crsz20 opened this issue Feb 13, 2024 · 0 comments

Comments

@crsz20
Copy link
Member

crsz20 commented Feb 13, 2024

Description
The LSM6DSOX provides two sensing capabilities: accelerometer and gyroscope. Each of them have been implemented separately as two classes, despite being the same device. This is not ideal, as they both would be sharing access to the same I2C peripheral in hardware.

Consolidate them into one, single class that inherits both IAccelerometer and IGyroscope.

In the Sensor layer, should the source code be kept in the Accelerometer or the Gyroscope folder?
Neither. Instead, make a new IMU folder.

Definition of Done

  • Tested
  • Improvement goals have been met
  • Code reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 What's Next
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants