-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Curtain 3 #218
Support Curtain 3 #218
Conversation
We can remove the passive detection of contact sensors by deleting the line with the 13 length. |
Thanks @the-ress |
Won’t that break pairing for people using contact sensors with passive bluetooth? |
No, because HA stores the sensor type in the config entry so it already knows what it is, it just means new ones can't be detected with passive only. Its pretty clear thats unsupported anyways https://github.com/home-assistant/core/blob/8a98a0e830e9381d9959d8b7b7e732b27f6be5ff/homeassistant/components/switchbot/strings.json#L47
|
That makes sense, thanks. |
Adds Curtain 3 support. Fixes home-assistant/core#99105.
It has a new model character (
{
/[
), but otherwise seems to work with the existing code. It also includes battery level in manufacturer data. I'm not sure if that's specific to Curtain 3, or firmware 0.7.In passive mode, Curtain 3 gets detected as a contact sensor because it has the same manufacturer data length. I couldn't figure out how to distinguish between them (and I don't have any contact sensors to investigate further).
Here are some manufacturer data values I recorded during testing.