You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
POST PR #1057 fragmented text broke based on comments below.
It is indeed the access to UTF8.decode in TextSourceBuffer.js which has been lost.
Replacing that decoder with the lines:
let dataView = new DataView(bytes, sampleList[i].offset, sampleList[i].size);
ccContent = new TextDecoder('utf-8').decode(dataView);
makes fragmented subtitling work again.
Using a data view is also more efficient than the current approach, but the approach above only works on brewers with TextDecoder.
The codem-isoboxer that we include has a fallback, but a poor one. I've made a PR to it with a better fallback (essentially the one from base64) together with new boxes for emsg. Maybe we can use it..
The text was updated successfully, but these errors were encountered:
POST PR #1057 fragmented text broke based on comments below.
It is indeed the access to UTF8.decode in TextSourceBuffer.js which has been lost.
Replacing that decoder with the lines:
makes fragmented subtitling work again.
Using a data view is also more efficient than the current approach, but the approach above only works on brewers with TextDecoder.
The codem-isoboxer that we include has a fallback, but a poor one. I've made a PR to it with a better fallback (essentially the one from base64) together with new boxes for emsg. Maybe we can use it..
The text was updated successfully, but these errors were encountered: