Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript typing file does not contain "SupplementalProperty" in the "dashjs.MediaInfo" #4061

Closed
Darkwinde opened this issue Sep 29, 2022 · 2 comments
Milestone

Comments

@Darkwinde
Copy link

Hi everybody,

in our MPD we defined an audio adaption set for Dolby Atmos. The identification is been done by the SupplementalProperty value "JOC" of the audio adaption set. Compared to Exo Player, Dash.JS does not provide a sample mime type, like "audio/eac3-joc", for identification therefor we need to stick to certain properties.

image

The issue is, that the typing file "index.d.ts" does not contain a definition for "SupplementalProperty" and therefor these information are not accessable within our Typescript project.

I like to request "SupplementalProperty" to be typed and made available to dashjs.MediaInfo.

@dsilhavy
Copy link
Collaborator

dsilhavy commented Nov 3, 2022

supplementalProperties is an object with the keys being the schemeIdUri of the SupplementalProperty and the values being the value of the SupplementalProperty. For instance:

{
"tag:dolby.com,2018:dash:EC3_ExtensionType:2018": "JOC",
"tag:dolby.com,2018:dash:EC3_ExtensionComplexityIndex:2018": "16"
}

for

<SupplementalProperty schemeIdUri="tag:dolby.com,2018:dash:EC3_ExtensionType:2018" value="JOC"/>
<SupplementalProperty schemeIdUri="tag:dolby.com,2018:dash:EC3_ExtensionComplexityIndex:2018" value="16"/>

I have added supplementalProperties to the Typescript definition file with type object in #4080 . Does this solve your problem?

@Darkwinde
Copy link
Author

Hi @dsilhavy,
I need to check this in the release version, but looks fine for me so far.

@dsilhavy dsilhavy modified the milestones: 4.5.1, 4.6.0 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants