Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation target type a union of int and float #1843

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented Jan 19, 2024

What does this PR do?

Additional Notes

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.

  • This PR does not rely on API client schema changes.

    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@nkzou nkzou requested a review from a team as a code owner January 19, 2024 15:58
@nkzou nkzou force-pushed the kevinzou/validation_include_float branch from 3dc0631 to 29410da Compare January 19, 2024 16:00
@nkzou nkzou merged commit 19b58e9 into master Jan 19, 2024
13 checks passed
@nkzou nkzou deleted the kevinzou/validation_include_float branch January 19, 2024 16:21
github-actions bot pushed a commit that referenced this pull request Jan 19, 2024
* make validation target union of int and float

* update template 19b58e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants