Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param retrieval for async client paginated calls #1951

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

garretruh
Copy link
Contributor

What does this PR do?

Fixes #1950

Additional Notes

Support for paginated methods in AsyncApiClient was added in #1615. Looking through the commits for that PR, it appears a get_pagination_params method was added in 6803354 and then removed in the subsequent d68565b in favor of gather_params. A couple call sites were updated but this one was not.

Review checklist

Please check relevant items below:

  • This PR includes all newly recorded cassettes for any modified tests.
  • This PR does not rely on API client schema changes.
    • The CI should be fully passing.
  • Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.
    • Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

@garretruh garretruh requested a review from a team as a code owner April 21, 2024 20:49
Copy link
Member

@skarimo skarimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skarimo skarimo merged commit cfc331c into DataDog:master Apr 25, 2024
12 of 13 checks passed
@garretruh garretruh deleted the bugfix/async-pagination-params branch April 27, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async client throws on paginated endpoint calls
2 participants