Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont inject content type on empty body #2079

Merged
merged 2 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .generator/src/generator/templates/rest.j2
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class RESTClientObject:
# For `POST`, `PUT`, `PATCH`, `OPTIONS`, `DELETE`
if method in ("POST", "PUT", "PATCH", "OPTIONS", "DELETE"):
# Only set a default Content-Type for POST, PUT, PATCH and OPTIONS requests
if method != "DELETE" and "Content-Type" not in headers:
if method != "DELETE" and "Content-Type" not in headers and body is not None:
headers["Content-Type"] = "application/json"
if query_params:
url += "?" + urlencode(query_params)
Expand Down
2 changes: 1 addition & 1 deletion src/datadog_api_client/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def request(
# For `POST`, `PUT`, `PATCH`, `OPTIONS`, `DELETE`
if method in ("POST", "PUT", "PATCH", "OPTIONS", "DELETE"):
# Only set a default Content-Type for POST, PUT, PATCH and OPTIONS requests
if method != "DELETE" and "Content-Type" not in headers:
if method != "DELETE" and "Content-Type" not in headers and body is not None:
headers["Content-Type"] = "application/json"
if query_params:
url += "?" + urlencode(query_params)
Expand Down
Loading