From 4f7242611001baac7f6a39798e347cdb611ad5ac Mon Sep 17 00:00:00 2001
From: Pierre Bonet <pierre.bonet@datadoghq.com>
Date: Thu, 30 May 2024 14:14:54 +0200
Subject: [PATCH] minor comments in the tests

---
 tests/ext/sidecar_disabled_when_telemetry_disabled.phpt | 4 ++++
 tests/ext/startup_logging_skipif_unix.inc               | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/ext/sidecar_disabled_when_telemetry_disabled.phpt b/tests/ext/sidecar_disabled_when_telemetry_disabled.phpt
index e1cb56b20cf..0f311a64086 100644
--- a/tests/ext/sidecar_disabled_when_telemetry_disabled.phpt
+++ b/tests/ext/sidecar_disabled_when_telemetry_disabled.phpt
@@ -6,6 +6,10 @@ Sidecar should be disabled when telemetry is disabled
 <?php
 include_once 'startup_logging.inc';
 
+// IN PHP 8.3, the sidecar is enabled
+// In all other versions the sidecar is disabled.
+// But we disable in all cases if telemetry is disabled.
+// So in this test, the sidecar should be disabled all the time
 $logs = dd_get_startup_logs([], [
     'DD_TRACE_DEBUG' => '1',
     'DD_INSTRUMENTATION_TELEMETRY_ENABLED' => '0',
diff --git a/tests/ext/startup_logging_skipif_unix.inc b/tests/ext/startup_logging_skipif_unix.inc
index 7f26af3c5b5..8788a920f09 100644
--- a/tests/ext/startup_logging_skipif_unix.inc
+++ b/tests/ext/startup_logging_skipif_unix.inc
@@ -3,4 +3,3 @@
 include_once 'startup_logging.inc';
 if (!dd_get_php_cgi()) die('skip: php-cgi SAPI required');
 if (strncasecmp(PHP_OS, "WIN", 3) == 0) die('skip: There is no background sender on Windows');
-// if ( version_compare(phpversion(),'8.3.0', '<')) die('skip: this test works only on PHP 8.3');