-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] profiling ZTS
builds
#2070
Comments
Which product are you asking for?
|
It was for profiling. Thanks for the info! What is the main reason behind the complexity?. Maybe we might think to work on it if we understand the underlying problem? |
May I ask what you are using ZTS builds for? What libraries and such are you using? Some of the complexity is that the PHP ABIs change for ZTS. The C macros that C extensions use don't always help since the profiler is primarily written in Rust. It's possible to support, I think, and is more of a matter of priority. Understanding what you are using ZTS builds for can help us understand the priority. |
We are thinking of integrating continuous profiling for https://docs.platform.sh/languages/php.html. And it currently uses ZTS. |
I wanted to use frankenphp as replacement for
|
Hey @sumerc / @piotrekkr, I just wanted to let you know that I'll working on bringing ZTS support to the profiler. A first PR to make it compile is already there, more to follow. I'll keep you posted. Kind regards |
Thanks for the update! |
Cool. Can't wait 👍 |
Hey @sumerc / @piotrekkr, we just released Let me know how this works for you! Kind regards |
Hey there 👋
The tracer also added support for FrankenPHP into this release. Thanks everyone for your patience 🙏 and in case you find anything, please open a Github Issue or reach out to support. |
Hi,
Is supporting
zts
builds something planned for the future, is there any issue for this? Sorry, if this is already discussed, but I can not seem to find an issue for that.The text was updated successfully, but these errors were encountered: