From 0599ce8fabad940feb48247c01b4e3e808e3ae5f Mon Sep 17 00:00:00 2001 From: steveny91 Date: Tue, 24 Sep 2024 11:01:26 +0200 Subject: [PATCH] lint --- dcgm/datadog_checks/dcgm/check.py | 2 +- dcgm/datadog_checks/dcgm/metrics.py | 2 +- dcgm/tests/conftest.py | 5 +++-- dcgm/tests/test_unit.py | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dcgm/datadog_checks/dcgm/check.py b/dcgm/datadog_checks/dcgm/check.py index 7fcc9cf0d7d11..f240715a2936b 100644 --- a/dcgm/datadog_checks/dcgm/check.py +++ b/dcgm/datadog_checks/dcgm/check.py @@ -3,7 +3,7 @@ # Licensed under a 3-clause BSD style license (see LICENSE) from datadog_checks.base import OpenMetricsBaseCheckV2 -from datadog_checks.dcgm.metrics import METRIC_MAP, RENAME_LABELS_MAP, IGNORED_TAGS +from datadog_checks.dcgm.metrics import IGNORED_TAGS, METRIC_MAP, RENAME_LABELS_MAP class DcgmCheck(OpenMetricsBaseCheckV2): diff --git a/dcgm/datadog_checks/dcgm/metrics.py b/dcgm/datadog_checks/dcgm/metrics.py index b7678c387b3bd..0ac8892a1fc31 100644 --- a/dcgm/datadog_checks/dcgm/metrics.py +++ b/dcgm/datadog_checks/dcgm/metrics.py @@ -63,4 +63,4 @@ "kube_namespace:.*", "pod_name:.*", "kube_container_name:.*", -] \ No newline at end of file +] diff --git a/dcgm/tests/conftest.py b/dcgm/tests/conftest.py index 180756e5f4c1b..fe3a75dd256b7 100644 --- a/dcgm/tests/conftest.py +++ b/dcgm/tests/conftest.py @@ -52,6 +52,7 @@ def mock_metrics(): ): yield + @pytest.fixture() def mock_label_remap(): f_name = os.path.join(os.path.dirname(__file__), 'fixtures', 'label_remap.txt') @@ -59,8 +60,8 @@ def mock_label_remap(): text_data = f.read() with mock.patch( 'requests.get', -return_value=mock.MagicMock( + return_value=mock.MagicMock( status_code=200, iter_lines=lambda **kwargs: text_data.split("\n"), headers={'Content-Type': "text/plain"} ), ): - yield \ No newline at end of file + yield diff --git a/dcgm/tests/test_unit.py b/dcgm/tests/test_unit.py index 3e172e306620f..911caad2cdd80 100644 --- a/dcgm/tests/test_unit.py +++ b/dcgm/tests/test_unit.py @@ -21,6 +21,7 @@ def test_critical_service_check(dd_run_check, aggregator, mock_http_response, ch dd_run_check(check) aggregator.assert_service_check('dcgm.openmetrics.health', status=check.CRITICAL) + @pytest.mark.usefixtures("mock_label_remap") def test_label_remap(dd_run_check, aggregator, check): """