Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] Unify FFI result types #563

Open
danielsn opened this issue Aug 1, 2024 · 0 comments
Open

[common] Unify FFI result types #563

danielsn opened this issue Aug 1, 2024 · 0 comments

Comments

@danielsn
Copy link
Contributor

danielsn commented Aug 1, 2024 

          Very likely for a separate PR as well, but it occurred to me that both `ddog_crasht_Result` and `ddog_prof_Profile_Result` are exactly the same `(dummy boolean, ddog_Error)` pair.

Furthermore, they already both use ddog_Error, so I'm thinking it may be relevant to introduce a shared ddog_Result.

Originally posted by @ivoanjo in #551 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielsn