Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow authenticating to the github API to avoid hitting rate limits #2183

Open
vandonr opened this issue Feb 28, 2024 · 0 comments
Open

Allow authenticating to the github API to avoid hitting rate limits #2183

vandonr opened this issue Feb 28, 2024 · 0 comments

Comments

@vandonr
Copy link
Contributor

vandonr commented Feb 28, 2024

some scripts depend on the github API (the one I had a problem with was dotnet/install_ddtrace.sh, which queries the API to get the latest version of the tracer), and when using them from a shared location (like the office), it's very easy to hit the rate limits, which in my case prevented me from rebuilding the image.

We could let users use the authenticated API instead, which has higher limits (and per-user limits instead of per-IP). They could do that by setting an env variable GITHUB_TOKEN, that'd have to be passed to docker, and used in the curl headers when necessary (and only if present, to avoid breaking everyone's workflow).
See https://docs.github.com/en/rest/authentication/authenticating-to-the-rest-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant