Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRC-542] [Feature] Lineage graph was Maximum text size in diagram exceeded #379

Open
tomoki-takahashi-oisix opened this issue Jul 5, 2024 · 3 comments
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync triage Triage required

Comments

@tomoki-takahashi-oisix
Copy link

tomoki-takahashi-oisix commented Jul 5, 2024

Describe the feature

I created a markdown for PR from the recce summary, but as shown below, there are too many related models, exceeding the display limit of the Lineage Graph.

スクリーンショット 2024-07-05 21 20 21

When launched with recce server, the lineage is displayed correctly as follows, but is it possible to add a feature to reduce the number of related lineages when creating a summary for PR using recce summary?

スクリーンショット 2024-07-05 21 24 03

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

DRC-542

@tomoki-takahashi-oisix tomoki-takahashi-oisix added enhancement New feature or request triage Triage required labels Jul 5, 2024
@even-wei even-wei added the linear Created by Linear-GitHub Sync label Jul 7, 2024
@even-wei even-wei changed the title [Feature] Lineage graph was Maximum text size in diagram exceeded [DRC-542] [Feature] Lineage graph was Maximum text size in diagram exceeded Jul 7, 2024
@even-wei
Copy link

even-wei commented Jul 7, 2024

Hi @tomoki-takahashi-oisix

Thanks for filing this issue.
This is a known issue, it's a hard limitation of GitHub PR comment.

Would you like to share with us the top-3 important things/nodes you want to see in this specific situation?
For example, showing modified/added/removed nodes only.
Or models with specific tags or groups?

@popcornylu
Copy link
Contributor

popcornylu commented Jul 8, 2024

There is the 65,536 chars limit in the PR comment. If you are running this in the ci, you can consider to put the markdown result in the job summary

@tomoki-takahashi-oisix
Copy link
Author

@even-wei

Thank you for your reply.
Personally, I would be happy if there was a feature that allows recce summary to be performed only on the results of "select models". If that's difficult, it might be good to have a filtering option like dbt's selector, such as -s 'hoge+1'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync triage Triage required
Projects
None yet
Development

No branches or pull requests

3 participants