Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRC-721] [Feature] support a different path for the production manifest #434

Open
noel opened this issue Sep 29, 2024 · 5 comments
Open
Labels
enhancement New feature or request kickoff Created by Linear-GitHub Sync linear Created by Linear-GitHub Sync triage Triage required
Milestone

Comments

@noel
Copy link

noel commented Sep 29, 2024

Describe the feature

Today Recce expects the production manifest to be at target-base/ I would like to pass a different location for the manifest. Ideally there would be a parameter like --base-manifest-path where I can pass a different location.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

DRC-721

@noel noel added enhancement New feature or request triage Triage required labels Sep 29, 2024
@clkao clkao added the linear Created by Linear-GitHub Sync label Sep 29, 2024
@popcornylu
Copy link
Contributor

Thank you for your suggestion.

In dbt, a similar option is --target-path, so we may lean towards using --target-base-path for consistency with other dbt commands. Additionally, this path doesn't just include the manifest, but also other artifacts like the catalog.

@popcornylu popcornylu added linear Created by Linear-GitHub Sync and removed linear Created by Linear-GitHub Sync labels Sep 30, 2024
@popcornylu popcornylu changed the title [Feature] support a different path for the production manifest [DRC-721] [Feature] support a different path for the production manifest Sep 30, 2024
@popcornylu popcornylu added this to the v.42 milestone Sep 30, 2024
@popcornylu popcornylu added the kickoff Created by Linear-GitHub Sync label Sep 30, 2024
@noel
Copy link
Author

noel commented Sep 30, 2024

Actually Dbt flag for this is —state

@popcornylu
Copy link
Contributor

Yes, thanks for the reminder. Indeed, the closest equivalent in dbt is --state, and we do use a mechanism like -s state:modified to determine modified nodes.

However, in the context of Recce, --state might conflict with specifying a state file. We are considering options like --state, --dbt-state, and --target-base-path to choose the most suitable one.

@popcornylu
Copy link
Contributor

Decide to use --target-base-path, and we will implement --target-path as well.

@noel
Copy link
Author

noel commented Oct 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kickoff Created by Linear-GitHub Sync linear Created by Linear-GitHub Sync triage Triage required
Projects
None yet
Development

No branches or pull requests

3 participants