Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Fails when Password Changes #115

Open
psycotica0 opened this issue Aug 8, 2016 · 2 comments
Open

Restart Fails when Password Changes #115

psycotica0 opened this issue Aug 8, 2016 · 2 comments

Comments

@psycotica0
Copy link

If you use the ansible role to change the auth for a server, it will rewrite the password in the config file.
To restart, though, the generated service uses the CLI interface to run commands, with the CLI interface reading from the config file we've already overwritten, so it just fails to auth to itself, since it's using the new password while the old server is still running.

This is made worse because the service just fires the CLI message and then takes it on faith that it will work, and goes into a while loop waiting for the pid file to disappear to declare success.

But, when there's an auth error and the server doesn't actually get the message about the restart, the restart service will block for all time.

@DavidWittman
Copy link
Owner

Thanks for reporting this issue, @psycotica0. We're probably better off using a SIGTERM to shutdown Redis as opposed to being forced to authenticate to run the shutdown command.

http://redis.io/topics/signals

@danielkza
Copy link
Contributor

This should be fixed when using the systemd in 1.2.0, as it does not use the CLI to shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants