Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parser files in Release Assets #234

Open
5 tasks
DerekStride opened this issue Dec 15, 2023 · 5 comments
Open
5 tasks

Include parser files in Release Assets #234

DerekStride opened this issue Dec 15, 2023 · 5 comments

Comments

@DerekStride
Copy link
Owner

DerekStride commented Dec 15, 2023

What

Currently the only assets included on the release are the source files (see https://github.com/DerekStride/tree-sitter-sql/releases/tag/v0.2.0). We should generate & add the parser files to the release as well. We could even precompile the parser for difference architectures and make that available too.

  • Add workflow to generate & add parsers files to release assets
  • build-wasm
  • Add workflow to precompile the parser & add to release assets
    • x86_64-darwin
    • x86_64-linux
@qoops-1
Copy link

qoops-1 commented Mar 16, 2024

It would also be great to have parser.c in the tagged commits for releases, not just the assets. Emacs has a built-in workflow to install tree-sitter grammars, which clones the repo at a specific tag and looks for parser.c file there. Because the releases are tagged on the main branch and not gh-pages file is not present there, so the workflow doesn't work for tagged releases in this repo

@matthias-Q
Copy link
Collaborator

@qoops-1 have a look at #120 We have discussed this issue already with the emacs guys. The problem is, that the parser.c is auto generated and gets quite large.

@qoops-1
Copy link

qoops-1 commented Mar 19, 2024

@matthias-Q thank you for the link, my takeaway from it is that current approach is to track hashes on gh-pages for corresponding tags of releases on main. It would be easier if gh-pages was also tagged, so that instead of hash I could specify that tag.

@DerekStride
Copy link
Owner Author

That might be possible with a custom release workflow

@clason
Copy link

clason commented Apr 21, 2024

On a related note, could you include the grammar.js in the gh-pages branch? Omitting this breaks nvim-treesitter's TSInstallFromGrammar.

EDIT Never mind, I see you include the grammar.json; that is good enough for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants