Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportPrivateUsage behaves differently when a global variable is modified inside a method on a class #679

Open
DetachHead opened this issue Sep 19, 2024 · 0 comments
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream

Comments

@DetachHead
Copy link
Owner

# foo.py

_foo = 1
_bar = 1

class Foo:
    def asdf(self) -> None:
        global _foo
        _foo = 1

def asdf():
    global _bar
    _bar = 1
# bar.py

from foo import _bar, _foo # error: reportPrivateUsage (on both)

print(_foo) # error: reportPrivateUsage
print(_bar) # no error

i think ideally it should only complain on the import. suppressing the error there should be enough to tell the type checker that you're using a private variable intentionally

@DetachHead DetachHead added type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream
Projects
None yet
Development

No branches or pull requests

1 participant