Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inlay hints when destructuring #692

Open
npip99 opened this issue Sep 23, 2024 · 2 comments
Open

Show inlay hints when destructuring #692

npip99 opened this issue Sep 23, 2024 · 2 comments

Comments

@npip99
Copy link

npip99 commented Sep 23, 2024

When using destructuring, inlay hints currently don't appear.

Screenshot 2024-09-22 at 6 58 47 PM

related: #349

(Potential Future Edge Case: Currently, for loops never show inlay hints, whether or not it's destructured. This issue could be relevant if inlay hints are included with for loops but not the destructured variants.)

@DetachHead
Copy link
Owner

do you want the inlay hints to show like this?

result: str, metadata: str = await task()

or like this?:

result, metadata: tuple[str, str] = await task()

i would probably prefer the first one. however i'm still on the fence about inlay hints that don't correspond to valid syntax, which is the case here. (related: #198)

@npip99
Copy link
Author

npip99 commented Sep 23, 2024

@DetachHead Hm, good question. In the example if you gave both are fine. But, if the list is long (e.g. 5-6+) items, I think it would have to be the first one or it'll be difficult to figure out which one maps to which simply by eye. So, I'd go with the first syntax.

Left my 2c on #198 , imo I just want max info because mouse hovering is annoying esp. for many items; bring to real-life isn't a use-case for me. Not sure whether or not my usage is actually representative of the average user though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants