Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

[feature] configurable notification system levels #1117

Open
infatrus opened this issue Jan 12, 2018 · 2 comments
Open

[feature] configurable notification system levels #1117

infatrus opened this issue Jan 12, 2018 · 2 comments

Comments

@infatrus
Copy link

System information

  • OS Platform and Distribution: Ubuntu 16.04.3 LTS (Xenial Xerus)
  • Zenbot version: unstable
  • NodeJS version: 8.9.4
  • Python version: -

Describe the problem

It would be nice to have possibility to configure notifications (eg. through conf.js).
For example:

  • in manual trade mode I would like to receive notifications about buy and sell signals only
  • in live mode I need only bought and sold
    and so on...
@firepol
Copy link
Contributor

firepol commented Jan 14, 2018

Hi,

Live mode: the notifications (bought and sold) are already working, I'm using them with telegram and they work also in paper mode. See in the conf-sample.js under c.notifiers.

Manual mode: looks like a good idea, I was also thinking that it would be really cool, especially when learning how this bot works, to just get the notification and then decide what to do.

Can you be more specific about "and so on"? If you write specific use cases that are missing, it's easier to implement them.

@infatrus
Copy link
Author

infatrus commented Jan 14, 2018

The idea behind is to give users control over kind and frequency of notifications, rather than to have them "hardcoded" in sources.
I can miss something... but there are four main modes: live, paper, manual and sim, also in manual mode, you can set limit order and market order. There is also a chance of an error occurring like getBalance. We have signals (buy, sell), information messages (buying, selling, bought, sold, balance), and condition messages (errors like getBalance). Users should have an easy control over all above, especially that in some cases (manual mode + limit order) user can get spammed with notifications (adjusting order - buying).

Maybe something like this:
notifiers = {
"notify": [
{ "mode":"live", "notification":[ "buy", "sell", "buying", "selling", "error" ] },
{ "mode":"manual", "notification":[ "buy", "sell", "error" ] },
{ "mode":"paper", "notification":[ "buying", "selling", "balance" ] }
]
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants