Update chainparams.cpp #143
Conversation
Seed Node Addition
ycagel
requested review from
saltedlolly,
SmartArray,
JaredTate,
ycagel,
gto90,
Sbosvk and
j50ng
Fix typo in dns name
|
tACK most recent commit |
There was a problem hiding this comment.
tACK
Looks good. I'm seeing several results for both.
Mainnet: https://www.whatsmydns.net/#A/seed.digibyte.services
Testnet: https://www.whatsmydns.net/#A/testnetseed.digibyte.services
|
I'm confused how we can have four approvals but still need one more?! Apparently all approvals are equal, but some approvals are more equal than others. 🐷🤣 |
|
I think I found the reason: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews "If your repository requires approving reviews from people with write or admin permissions, then any approvals from people with these permissions are denoted with a green check mark, and approvals from people without these permissions have a gray check mark. Approvals with a gray check mark do not affect whether the pull request can be merged." |
Seed Node Addition for Mainnet and Testnet