Fix libpng warning: iCCP: known incorrect sRGB profile

[ghost]

debug.log: GUI: libpng warning: iCCP: known incorrect sRGB profile

Update sRGB profile of 49 images in src/qt/res/icons/

After PR:

[ghost]

Maybe it also fix this on Windows QT. Not tested yet:

#164 (comment)

[beggsdl]

I will test this to see if it helps with #164

[ghost]

I will test this to see if it helps with #164

Ty! I don't think it will fix PR164. But maybe it helps with some errors in your log.

[JaredTate]

Thanks for looking into this. So this compiles and runs, but from what I can see the only thing actually changing is the addition of an empty digibyte.ico file. The ICO file format is an image file format for computer icons in Microsoft Windows. So until we add the complete digibyte.ico file back this won't change anything on windows and does nothing for other distros.

[saltedlolly]

It would be nice to give the icons and QT UI a little polish for v8. Nothing drastic, just something to give it that new car smell. No need to change the logo, just swap it for a polished version. I like those 3D effect DigiByte logos Shane did.

[saltedlolly]

https://t.me/Shane_DGB_Media/354

[saltedlolly]

MAybe it would be nice to change up the color scheme as well. DigiByte blue is great, but one of the nice things about the Bitcoin logo (and the DigiByte logo) is that they work in any color. I'm not a designer but I'm sure we could find someone to help.

[ghost]

Thanks for looking into this. So this compiles and runs, but from what I can see the only thing actually changing is the addition of an empty digibyte.ico file. The ICO file format is an image file format for computer icons in Microsoft Windows. So until we add the complete digibyte.ico file back this won't change anything on windows and does nothing for other distros.

Look in your debug.log the warning/error is gonne.( libpng warning: iCCP: known incorrect sRGB profile)
From every image i remove the incorrect sRGB profile.

This are the old and new images files. Look at the size of each image.

[JaredTate]

MAybe it would be nice to change up the color scheme as well. DigiByte blue is great, but one of the nice things about the Bitcoin logo (and the DigiByte logo) is that they work in any color. I'm not a designer but I'm sure we could find someone to help.

If someone has the time to upgrade the icons by all means we can do it. I am not a designer either. I will say on macOS it uses your operating system theme colors, so you could get some wonky looks. For example this is how my client looks on my mac:

[JaredTate]

Thanks for looking into this. So this compiles and runs, but from what I can see the only thing actually changing is the addition of an empty digibyte.ico file. The ICO file format is an image file format for computer icons in Microsoft Windows. So until we add the complete digibyte.ico file back this won't change anything on windows and does nothing for other distros.

Look in your debug.log the warning/error is gonne.( libpng warning: iCCP: known incorrect sRGB profile) From every image i remove the incorrect sRGB profile.

This are the old and new images files. Look at the size of each image.

Ah ok, I now see what you are talking about with sRGB. Github still shows the digibyte.ico being blank though. I see the deletions and additions with different sRGB profile.

[ghost]

It is a GitHub problem! This fix was not intended for Windows. Global fix. But I'm now testing it in Windows and it seems to fix that to. This #164 (comment) issue. You see lot of errors in debug.log. On my windows install i don't see them. With this PR. Not yet tested without this PR.

[beggsdl]

It would be nice to give the icons and QT UI a little polish for v8. Nothing drastic, just something to give it that new car smell. No need to change the logo, just swap it for a polished version. I like those 3D effect DigiByte logos Shane did.

The icons are already updated from v7 (Windows OS, v7 on top, v8 on bottom).

I do like that logo you posted. The logo is currently the same between v7 and v8, so I think a refresh of that would look good.

[beggsdl]

It is a GitHub problem! This fix was not intended for Windows. Global fix. But I'm now testing it in Windows and it seems to fix that to. This #164 (comment) issue. You see lot of errors in debug.log. On my windows install i don't see them. With this PR. Not yet tested without this PR.

Specifically which errors in the debug.log file on Windows are you referring to? I am curious, because all those errors in what I had posted would not show up for many hours of running. And then several hours after they appeared, it would crash.

[ghost]

It is a GitHub problem! This fix was not intended for Windows. Global fix. But I'm now testing it in Windows and it seems to fix that to. This #164 (comment) issue. You see lot of errors in debug.log. On my windows install i don't see them. With this PR. Not yet tested without this PR.

Specifically which errors in the debug.log file on Windows are you referring to? I am curious, because all those errors in what I had posted would not show up for many hours of running. And then several hours after they appeared, it would crash.

Ok, I'm curious to see if your node still crashes. and if so, share the debug.log please. Is the node running with this pr?

[JaredTate]

ACK. I went ahead and GUIX built the windows.exe binary. Everything looks good, compiles and runs. Thanks for this update!

[ghost]

ACK. I went ahead and GUIX built the windows.exe binary. Everything looks good, compiles and runs. Thanks for this update!

Thank you for all your time to review. I would try to provide more text and explanation in the next PR.

[saltedlolly]

MAybe it would be nice to change up the color scheme as well. DigiByte blue is great, but one of the nice things about the Bitcoin logo (and the DigiByte logo) is that they work in any color. I'm not a designer but I'm sure we could find someone to help.

If someone has the time to upgrade the icons by all means we can do it. I am not a designer either. I will say on macOS it uses your operating system theme colors, so you could get some wonky looks. For example this is how my client looks on my mac:

Does QT handle switching between dark and light mode? Can it support adding a difent logo for dark mode and light mode on Mac?

[ghost]

MAybe it would be nice to change up the color scheme as well. DigiByte blue is great, but one of the nice things about the Bitcoin logo (and the DigiByte logo) is that they work in any color. I'm not a designer but I'm sure we could find someone to help.

If someone has the time to upgrade the icons by all means we can do it. I am not a designer either. I will say on macOS it uses your operating system theme colors, so you could get some wonky looks. For example this is how my client looks on my mac:

Does QT handle switching between dark and light mode? Can it support adding a difent logo for dark mode and light mode on Mac?

At the moment there is only one logo for dark and light mode.

[ycagel]

cACK. Thank you to everyone for their efforts in testing.

[gto90]

cACK.

Thanks for the effort on cleaning up all these assets!