Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make check #175

Closed
wants to merge 14 commits into from
Closed

Fix: Make check #175

wants to merge 14 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2024

Make check without errors. Running > 95% of the tests.

Screenshot from 2024-02-21 16-07-38

Needs PR174

@gto90 gto90 assigned gto90 and ghost and unassigned gto90 Feb 21, 2024
@ghost ghost marked this pull request as draft February 21, 2024 18:39
@gto90
Copy link
Member

gto90 commented Feb 21, 2024

@Jongjan88 , thank you so much for your continued help with resolving the test failures. I left some comments but now that I see you put the PR in draft form those comments may be moot. Feel free to just dismiss my comments if you are still working on the tests.

@JaredTate
Copy link

Thanks for starting on this, I see you commented several out, I assume you will go back on these? I will start in tonight/ tomorrow on some tests. We cold coordinate an attack plan. I see this is draft status.

@ghost
Copy link
Author

ghost commented Feb 23, 2024

Thanks for starting on this, I see you commented several out, I assume you will go back on these? I will start in tonight/ tomorrow on some tests. We cold coordinate an attack plan. I see this is draft status.

Of course. I wanted to share what I found so far. And make it a little easier for others. I'll start working on it tomorrow.
(Now_01:28_AM) shouldn't have made a PR out of this. Is there a channel / IRC for devs?

@ghost ghost closed this Feb 23, 2024
@ghost ghost deleted the test branch February 23, 2024 22:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants