Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max / Rpc tx fee. #176

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Max / Rpc tx fee. #176

merged 5 commits into from
Feb 23, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2024

Max tx fee

src/node/transaction.h
COIN / 10 >> COIN * 100

constexpr CAmount DEFAULT_TRANSACTION_MAXFEE{COIN * 100};

gto90
gto90 previously approved these changes Feb 21, 2024
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Thank you for the contribution!

@ghost ghost requested a review from gto90 February 21, 2024 23:55
@ghost
Copy link
Author

ghost commented Feb 21, 2024

cACK

Thank you for the contribution!

I change one value. Hope you can review again.
4294967295 > 4000000000

gto90
gto90 previously approved these changes Feb 22, 2024
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

ycagel
ycagel previously approved these changes Feb 22, 2024
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@ghost
Copy link
Author

ghost commented Feb 22, 2024

Sorry i remove some code from the pr. Now the pr is 100% working! Next time i will do more tests before making a PR. i think i use yesterday the wrong binary. The old RPC value's are working correctly. 0.1dgb / 100dgb.

@ghost ghost dismissed stale reviews from ycagel and gto90 via ce211ca February 22, 2024 13:40
@ghost ghost requested review from ycagel and gto90 February 22, 2024 13:51
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles & runs. Looks good. Thank you for the work on this!

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks @Jongjan88!

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@gto90 gto90 merged commit dd95b35 into DigiByte-Core:develop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants