Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Version to 8.22.0-RC4 #217

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

JaredTate
Copy link

It would be great to cut an RC4 release here shortly. I think now that all failing tests have been fixed, Apple Silicon is compiling, and with all the changes we have made it would be a great time to cut a release fixing a lot of problems and get more testers on board.

I can GUIX build the release and tag it, but I would love to have descriptors as default in an RC4 for more testing. So PR #213 still needs approved.

Big thanks to @saltedlolly for thinking ahead with the RC4 graphic in #170.

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@saltedlolly
Copy link

Good plan.

Could we please try and ensure that the file and folder names are consistent this time? It might be good to update GUIX to ensure that the builds follow the file and folder naming conventions discussed here: #138

Also, I really think it would a good policy to have a few of us build RC4 and generate keys to sign off on it like we did for RC2. We did not do this for RC3. These binaries are easy for non-developers to download, even if they are pre-releases, and I think it would be worth taking the extra steps to have a few of us sign them. (Say at least three people.) People should not have to trust any one developer to compile. If a few of us sign them then they don't have to.

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gto90 gto90 merged commit 0a82000 into DigiByte-Core:develop Mar 25, 2024
@JaredTate
Copy link
Author

Good plan.

Could we please try and ensure that the file and folder names are consistent this time? It might be good to update GUIX to ensure that the builds follow the file and folder naming conventions discussed here: #138

Also, I really think it would a good policy to have a few of us build RC4 and generate keys to sign off on it like we did for RC2. We did not do this for RC3. These binaries are easy for non-developers to download, even if they are pre-releases, and I think it would be worth taking the extra steps to have a few of us sign them. (Say at least three people.) People should not have to trust any one developer to compile. If a few of us sign them then they don't have to.

I have no problem signing an RC4, but it will take us a lot longer for a release. We definitely need to sign the final 8.22.0 release. The thing is the commit hash is verified when you upload binaries built from the specific tag, so anyone can easily verify the build that way. There is a green checkmark.

As for the file & folder names, the commit hash is required to be in the naming as part of the signing process. So I am not sure what file name/folder structure you are looking for, but it will mess up the actual GUIX signing process by removing commit hashes in file/ folder names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants