Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Qt 5.9 source URL #50

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

Jolly-Pirate
Copy link

The Windows binaries fail to build because of an invalid Qt 5.9 URL. As it turns out, https://download.qt.io/official_releases/qt/ doesn't provide that version anymore, the minimum official version is 5.12. However, Qt 5.9 can be found at the archive https://download.qt.io/archive/qt/5.9/

The Windows binaries fail to build because of an invalid Qt 5.9 URL. As it turns out, https://download.qt.io/official_releases/qt/ doesn't provide that version anymore, the minimum official version is 5.12. However, Qt 5.9 can be found at the archive https://download.qt.io/archive/qt/5.9/
@SmartArray SmartArray self-requested a review June 11, 2021 13:46
Copy link

@SmartArray SmartArray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me. Thanks for your contribution!

utACK, as I have no Microsoft Windows to test it. However, having worked with Qt a lot in the past, I know that as long as the major version stays the same, everything should work as expected!

@SmartArray SmartArray self-assigned this Jun 11, 2021
@SmartArray SmartArray added the bug Something isn't working label Jun 11, 2021
Copy link

@ChillingSilence ChillingSilence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, we're using 5.9.6, this fixes the URL, thank you @Jolly-Pirate

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thanks kindly for the contribution!

@gto90 gto90 merged commit a57f772 into DigiByte-Core:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants