Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter Transformation #32

Open
1 of 15 tasks
ebeshero opened this issue May 24, 2019 · 2 comments
Open
1 of 15 tasks

Letter Transformation #32

ebeshero opened this issue May 24, 2019 · 2 comments
Assignees
Labels

Comments

@ebeshero
Copy link
Member

ebeshero commented May 24, 2019

  • insertions above line need to be rendered above line
  • Make sure the double hyphen is transformed with XSLT into an em dash
  • Check <emph>, <emph rend="underline">, <hi rend="underline">. Decide if we want <emph> to be underlining (like MRM's writing), or italics.
  • Check around <del> elements. If (and only if) there is NOT a white space following a deletion, add a white space for legibility. BE CAREFUL if a deletion is contained inside a word. THINK ABOUT THIS CAREFULLY AND TEST.

OTHER BUGS (LMW) (may be transformation or may need to be corrected in the letter xml or letter template):

  • Check clickable buttons on letter page and on individual letters to make clear they are clickable.
  • Why are red hyphens appearing sometimes between words in the letter output?
  • Check puncuation on list of photo jpgs (may be xml proofing issue):
    Example:
    IMG_0200.jpg, IMG_0201.jpg, IMG_0202.jpg, IMG_0203.jpg, IMG_0204.jpg, IMG_0205.jpg, IMG_0206.jpg, IMG_0207.jpg, IMG_0208.jpg, IMG_0209.jpg, IMG_0210.jpg, IMG_0211.jpg, .
  • Description of STAMPS from the header that appear in left nav bar: missing spaces between sentences and missing or additional line breaks and odd punctuation; for example, around READING placeName tag (do we need to correct letter template?):
    1819-Jan-09 EXAMPLE:
    One and one-half sheets of folio paper, six surfaces photographed.Address leaf bearing black circular mileage stamp, partially illegible, reading
    READING
    .Half sheet (pages five and six) torn on right edge where wax seal was removed.Black wax seal, remnants of black wax adhered elsewhere on page six.
  • Check spacing around tags: should be right next to the word noted, with no extra space. (Likely wrong in the xml.)
  • Check spacing around tags: Do we want these to appear with spaces or no spaces?
  • Check spacing on letter openers, especially in dateline, address lines (do we need to correct letter template?) (Even if MRM writes address line info on the same line, there should be a space between elements and lb for salutation):
    Example:
    Bertram HouseJany12th 1819. My dear Sir
  • Check similar spacing issue on address block of letters, especially elements MRM writes on the same line.
    Example:
    ReadingJanuary ninth
    1819
  • Check spacing when two context tags appear next to each other: why is space between words eliminated?:
    Example:
    great men--BaconShakespeare & so forth,

A couple extra considerations (SLC):

  • Check for text overlapping images/other text instead of being pushed down when the zoom feature is used.
  • Is there anyway to make the page more tablet/phone friendly? Much of the header gets cut off on a smaller screen.
@ebeshero ebeshero added the bug label May 24, 2019
@ebeshero ebeshero self-assigned this May 24, 2019
@lmwilson
Copy link

@ebeshero Here is the list of letter-output bugs Becca, Sara, and I generated in May and your to-do list.

@ebeshero
Copy link
Member Author

Aha! Thanks for finding it and reminding me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants