Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independently version docker image and EE #1156

Closed
kirtangajjar opened this issue Aug 6, 2018 · 2 comments
Closed

Independently version docker image and EE #1156

kirtangajjar opened this issue Aug 6, 2018 · 2 comments

Comments

@kirtangajjar
Copy link
Contributor

kirtangajjar commented Aug 6, 2018

Currently EE version "4.0.0-beta.5" will try to pull image tagged "v4.0.0-beta.5" off all containers. This means we would have to update docker images even if there wasn't any change in it.

This isn't the ideal case and both EE and docker image versions can be independent. Then we can have EE version 4.0.0-beta.5 can depend on a specific docker image verison i.e. easyengine/php:1.3.0 and so on...

@kirtangajjar kirtangajjar changed the title Independently version docker image and EE version Independently version docker image and EE Aug 6, 2018
@rahul286
Copy link
Member

rahul286 commented Aug 6, 2018

Agree with you.

https://github.com/EasyEngine/dockerfiles/releases should have been independently versioned. Sorry I missed that.

Ideally, I would have started them versioning 0.1, 0.2 and so on with the goal of reaching dockerfiles v1.0 with ee v4.0.

If there is any special reason to map version numbers, please elaborate.

@kirtangajjar
Copy link
Contributor Author

If there is any special reason to map version numbers, please elaborate.

Earlier we thought it was best way to go forward since in each release, there were changes in image itself and it was mandatory to update the image. So we put a constraint that the code will pull the version of image matching current easyengine version.

However since last 2 releases, there are minor changes in few images but still we have to update every image because of this constraint. So now it's clear to us that there's no benefit in coupling easyengine and docker image versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants