-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to independently version docker images #1166
Add support to independently version docker images #1166
Conversation
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
img-versions.json
Outdated
@@ -0,0 +1,10 @@ | |||
{ | |||
"easyengine/mailhog": "v4.0.0-beta.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be using this docker image version from this file to all the places now. https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39
https://github.com/EasyEngine/site-wp-command/blob/develop/src/Site_WP_Docker.php#L128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will updated in https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L39
For site-command
and site-wp-command
:
EasyEngine/site-command#95
EasyEngine/site-type-wp#15
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Closes #1156